Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(form:select): correct trigger onSearch in reset when set value #1660

Merged
merged 1 commit into from
Oct 19, 2023
Merged

fix(form:select): correct trigger onSearch in reset when set value #1660

merged 1 commit into from
Oct 19, 2023

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Oct 19, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@ng-alain-bot
Copy link
Contributor

ng-alain-bot commented Oct 19, 2023 •
edited
Loading

Preview is ready!

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #1660 (5dbeaeb) into master (5edaa97) will decrease coverage by 0.03%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

❗ Current head 5dbeaeb differs from pull request most recent head ae2195d. Consider uploading reports for the commit ae2195d to get more accurate results

@@            Coverage Diff             @@
##           master    #1660      +/-   ##
==========================================
- Coverage   95.53%   95.51%   -0.03%     
==========================================
  Files         282      282              
  Lines        8756     8758       +2     
  Branches     1648     1649       +1     
==========================================
  Hits         8365     8365              
- Misses        323      324       +1     
- Partials       68       69       +1
Files Coverage Δ
packages/form/src/widgets/select/select.widget.ts 96.42% <100.00%> (+0.13%) ⬆️

... and 1 file with indirect coverage changes

@cipchk cipchk merged commit fa234cd into master Oct 19, 2023
9 checks passed
@cipchk cipchk deleted the issues-2427 branch October 19, 2023 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

form select 设置 onSearch后无法使用设置enum来显示默认值
2 participants
@cipchk @ng-alain-bot